netdev - Re: [net-next 1/1] tipc: fix bug during lookup of multicast destination nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180115.142729.659157027252943827.davem@davemloft.net>
Date:   Mon, 15 Jan 2018 14:27:29 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jon.maloy@...csson.com
Cc:     netdev@...r.kernel.org,
        mohan.krishna.ghanta.krishnamurthy@...csson.com,
        tung.q.nguyen@...tech.com.au, hoang.h.le@...tech.com.au,
        canh.d.luu@...tech.com.au, ying.xue@...driver.com,
        tipc-discussion@...ts.sourceforge.net
Subject: Re: [net-next 1/1] tipc: fix bug during lookup of multicast
 destination nodes

From: Jon Maloy <jon.maloy@...csson.com>
Date: Fri, 12 Jan 2018 20:56:50 +0100

> In commit 232d07b74a33 ("tipc: improve groupcast scope handling") we
> inadvertently broke non-group multicast transmission when changing the
> parameter 'domain' to 'scope' in the function
> tipc_nametbl_lookup_dst_nodes(). We missed to make the corresponding
> change in the calling function, with the result that the lookup always
> fails.
> 
> A closer anaysis reveals that this parameter is not needed at all.
> Non-group multicast is hard coded to use CLUSTER_SCOPE, and in the
> current implementation this will be delivered to all matching
> destinations except those which are published with NODE_SCOPE on other
> nodes. Since such publications never will be visible on the sending node
> anyway, it makes no sense to discriminate by scope at all.
> 
> We now remove this parameter altogether.
> 
> Signed-off-by: Jon Maloy <jon.maloy@...csson.com>

Applied, thanks Jon.