netdev - Re: [PATCH bpf-next] bpftool: recognize BPF_PROG_TYPE_CGROUP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 15 Jan 2018 19:32:01 +0000
From:   Quentin Monnet <quentin.monnet@...ronome.com>
To:     Roman Gushchin <guro@...com>, netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, kernel-team@...com,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...nel.org>
Subject: Re: [PATCH bpf-next] bpftool: recognize BPF_PROG_TYPE_CGROUP_DEVICE
 programs

2018-01-15 19:16 UTC+0000 ~ Roman Gushchin <guro@...com>
> Bpftool doesn't recognize BPF_PROG_TYPE_CGROUP_DEVICE programs,
> so the prog show command prints the numeric type value:
>
> $ bpftool prog show
> 1: type 15  name bpf_prog1  tag ac9f93dbfd6d9b74
> 	loaded_at Jan 15/07:58  uid 0
> 	xlated 96B  jited 105B  memlock 4096B
>
> This patch defines the corresponding textual representation:
>
> $ bpftool prog show
> 1: cgroup_device  name bpf_prog1  tag ac9f93dbfd6d9b74
> 	loaded_at Jan 15/07:58  uid 0
> 	xlated 96B  jited 105B  memlock 4096B
>
> Signed-off-by: Roman Gushchin <guro@...com>
> Cc: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Cc: Quentin Monnet <quentin.monnet@...ronome.com>
> Cc: Daniel Borkmann <daniel@...earbox.net>
> Cc: Alexei Starovoitov <ast@...nel.org>
> ---
>  tools/bpf/bpftool/prog.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tools/bpf/bpftool/prog.c b/tools/bpf/bpftool/prog.c
> index c6a28be4665c..099e21cf1b5c 100644
> --- a/tools/bpf/bpftool/prog.c
> +++ b/tools/bpf/bpftool/prog.c
> @@ -66,6 +66,7 @@ static const char * const prog_type_name[] = {
>  	[BPF_PROG_TYPE_LWT_XMIT]	= "lwt_xmit",
>  	[BPF_PROG_TYPE_SOCK_OPS]	= "sock_ops",
>  	[BPF_PROG_TYPE_SK_SKB]		= "sk_skb",
> +	[BPF_PROG_TYPE_CGROUP_DEVICE]	= "cgroup_device",
>  };
>  
>  static void print_boot_time(__u64 nsecs, char *buf, unsigned int size)

Looks good, thanks Roman!
Would you mind updating the map names as well? It seems the
BPF_MAP_TYPE_CPUMAP is missing from the list in map.c.

Quentin