netdev - Re: hyperv/netvsc: Delete two error messages for a failed memory allocation in netvsc_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c7ffcb1d-107c-c49b-b3bf-9b0f260e7214@users.sourceforge.net>
Date:   Mon, 15 Jan 2018 10:00:11 +0100
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Haiyang Zhang <haiyangz@...rosoft.com>,
        devel@...uxdriverproject.org, netdev@...r.kernel.org
Cc:     KY Srinivasan <kys@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: hyperv/netvsc: Delete two error messages for a failed memory
 allocation in netvsc_init_buf()

> These messages are not displayed anywhere else:
> "unable to allocate receive buffer of size %u\n"
> "unable to allocate send buffer of size %u\n",
> 
> After set ret = -ENOMEM; and cleanup, we won't know which buffer allocation failed without the error message.

How do you think about to achieve the distinction for these buffers by any other means?

Can a detailed function call stack dump be appropriate?


> So please do not remove these messages.

Would you dare to adjust this function implementation in any other ways?

Regards,
Markus