netdev - Re: [PATCH v2 net-next 0/5] l2tp: set l2specific_len based on l2specific

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180116115010.GI1422@alphalink.fr>
Date:   Tue, 16 Jan 2018 12:50:10 +0100
From:   Guillaume Nault <g.nault@...halink.fr>
To:     Lorenzo Bianconi <lorenzo.bianconi@...hat.com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        James Chapman <jchapman@...alix.com>
Subject: Re: [PATCH v2 net-next 0/5] l2tp: set l2specific_len based on
 l2specific_type

On Tue, Jan 16, 2018 at 12:45:06PM +0100, Lorenzo Bianconi wrote:
> > On Sun, Jan 14, 2018 at 03:50:53PM +0100, Lorenzo Bianconi wrote:
> >> Do not rely on l2specific_len value provided by userspace but set sublayer
> >> length according to l2specific_type.
> >> Fix a harmless issue in the switch default case in
> >> l2tp_nl_cmd_session_create().
> >>
> >> Changes since v1:
> >> - remove l2specific_len parameter
> >> - add sanity check on l2specific_type provided by userspace
> >>
> > Thanks for working on this Lorenzo.
> >
> > Whatever the discussions on patches 1 and 3 lead to:
> >
> > Reviewed-by: Guillaume Nault <g.nault@...halink.fr>
> > Tested-by: Guillaume Nault <g.nault@...halink.fr>
> 
> I will send a v3 later today dropping the first patch (I will send a
> single one removing the switch later) and including your suggestion
> for default case in  l2tp_get_l2specific_len().
> Thanks for reviewing the patch :)
> 
Great! Feel free to keep my Reviewed-by: and Tested-by: tags.

Regards,

Guillaume