netdev - Re: [PATCH v8 4/5] can: m

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1b879e98-27a9-8117-c159-5473917a20cb@pengutronix.de>
Date:   Tue, 16 Jan 2018 13:57:40 +0100
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Faiz Abbas <faiz_abbas@...com>, wg@...ndegger.com,
        robh+dt@...nel.org, mark.rutland@....com
Cc:     linux-can@...r.kernel.org, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        nsekhar@...com, fcooper@...com, robh@...nel.org,
        Wenyou.Yang@...rochip.com, sergei.shtylyov@...entembedded.com,
        linux-omap@...r.kernel.org, b29396@...escale.com
Subject: Re: [PATCH v8 4/5] can: m_can: Add PM Support

On 01/16/2018 12:37 PM, Faiz Abbas wrote:
> Add support for CONFIG_PM which is the new way to handle managing clocks.
> 
> Move the clock management to pm_runtime_resume() and pm_runtime_suspend()
> callbacks for the driver.
> 
> CONFIG_PM is required by OMAP based devices to handle clock management.
> Therefore, this allows future Texas Instruments SoCs that have the MCAN IP
> to work with this driver.
> 
> Signed-off-by: Faiz Abbas <faiz_abbas@...com>

Fixed this while applying:

drivers/net/can/m_can/m_can.c:1752:5: warning: symbol
'm_can_runtime_suspend' was not declared. Should it be static?
drivers/net/can/m_can/m_can.c:1763:5: warning: symbol
'm_can_runtime_resume' was not declared. Should it be static?

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)