netdev - Re: [PATCH] netfilter: nf_tables: flow_offload depends on flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180116004852.ly4nzjgkhspdzftd@salvia>
Date:   Tue, 16 Jan 2018 01:48:52 +0100
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
        Florian Westphal <fw@...len.de>,
        "David S. Miller" <davem@...emloft.net>,
        William Breathitt Gray <vilhelm.gray@...il.com>,
        "Pablo M. Bermudo Garay" <pablombg@...il.com>,
        Manuel Messner <mm@...lett.io>,
        netfilter-devel@...r.kernel.org, coreteam@...filter.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] netfilter: nf_tables: flow_offload depends on flow_table

On Fri, Jan 12, 2018 at 04:50:26PM +0100, Arnd Bergmann wrote:
> Without CONFIG_NF_FLOW_TABLE, the new nft_flow_offload module produces
> a link error:
> 
> net/netfilter/nft_flow_offload.o: In function `nft_flow_offload_iterate_cleanup':
> nft_flow_offload.c:(.text+0xb0): undefined reference to `nf_flow_table_iterate'
> net/netfilter/nft_flow_offload.o: In function `flow_offload_iterate_cleanup':
> nft_flow_offload.c:(.text+0x160): undefined reference to `flow_offload_dead'
> net/netfilter/nft_flow_offload.o: In function `nft_flow_offload_eval':
> nft_flow_offload.c:(.text+0xc4c): undefined reference to `flow_offload_alloc'
> nft_flow_offload.c:(.text+0xc64): undefined reference to `flow_offload_add'
> nft_flow_offload.c:(.text+0xc94): undefined reference to `flow_offload_free'
> 
> This adds a Kconfig dependency for it.

Applied, thanks Arnd.