netdev - Re: [PATCH bpf-next 11/11] selftests/bpf: add checks on extack messages for eBPF hw offload tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180115165511.1a858f8d@cakuba.netronome.com>
Date:   Mon, 15 Jan 2018 16:55:11 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     David Ahern <dsahern@...il.com>
Cc:     davem@...emloft.net, daniel@...earbox.net,
        alexei.starovoitov@...il.com, netdev@...r.kernel.org,
        oss-drivers@...ronome.com, jiri@...nulli.us,
        john.fastabend@...il.com, jhs@...atatu.com, gerlitz.or@...il.com,
        aring@...atatu.com, xiyou.wangcong@...il.com,
        Quentin Monnet <quentin.monnet@...ronome.com>
Subject: Re: [PATCH bpf-next 11/11] selftests/bpf: add checks on extack
 messages for eBPF hw offload tests

On Mon, 15 Jan 2018 17:49:07 -0700, David Ahern wrote:
> On 1/15/18 5:30 PM, Jakub Kicinski wrote:
> > A new flag ("--skip-extack") is added to the Python script so as to
> > allow to skip these checks. This is because extack messages cannot be
> > displayed by tc and ip if tools from iproute2 package were compiled
> > without libmnl, but we do not want this to prevent users to run the
> > other checks.  
> 
> That is unfortunate. Did you consider auto-detecting support? e.g., run
> a command that is known to fail and return a message. For example,
> 
> $ ip ro add 1.1.1.1/32 dev eth0 onlink
> Error: Invalid flags for nexthop - PERVASIVE and ONLINK can not be set.

That's a good idea.  And then if it fails would you suggest to skip the
test entirely or just skip extack checks?  With the --skip-extack flag
the hope was that people would be inclined to install libmnl to save
themselves the hassle of setting the flag each time.  If it's detected
automatically there is no hassle/nudge to install libmnl..