netdev - Re: [PATCH] qed: Fix potential use-after-free in qed_spq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180116.145752.1483453106774774130.davem@davemloft.net>
Date:   Tue, 16 Jan 2018 14:57:52 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     roland@...nel.org
Cc:     Ariel.Elior@...ium.com, everest-linux-l2@...ium.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH] qed: Fix potential use-after-free in qed_spq_post()

From: Roland Dreier <roland@...nel.org>
Date: Mon, 15 Jan 2018 12:24:49 -0800

> From: Roland Dreier <roland@...estorage.com>
> 
> We need to check if p_ent->comp_mode is QED_SPQ_MODE_EBLOCK before
> calling qed_spq_add_entry().  The test is fine is the mode is EBLOCK,
> but if it isn't then qed_spq_add_entry() might kfree(p_ent).
> 
> Signed-off-by: Roland Dreier <roland@...estorage.com>

Applied, thanks Roland.