lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20180116020845.3496-4-jakub.kicinski@netronome.com> Date: Mon, 15 Jan 2018 18:08:37 -0800 From: Jakub Kicinski <jakub.kicinski@...ronome.com> To: davem@...emloft.net, daniel@...earbox.net, alexei.starovoitov@...il.com, netdev@...r.kernel.org Cc: dsahern@...il.com, oss-drivers@...ronome.com, jiri@...nulli.us, john.fastabend@...il.com, jhs@...atatu.com, gerlitz.or@...il.com, aring@...atatu.com, xiyou.wangcong@...il.com, Quentin Monnet <quentin.monnet@...ronome.com> Subject: [PATCH bpf-next v2 03/11] net: sched: cls_flower: propagate extack support for filter offload From: Quentin Monnet <quentin.monnet@...ronome.com> Propagate the extack pointer from the `->change()` classifier operation to the function used for filter replacement in cls_flower, and feed it to tc_cls_common_offload_init(). This makes it possible to use netlink extack messages in the future at replacement time for this filter, although it is not used at this point. Signed-off-by: Quentin Monnet <quentin.monnet@...ronome.com> Reviewed-by: Jakub Kicinski <jakub.kicinski@...ronome.com> --- net/sched/cls_flower.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c index f1640a98a3d2..fe7d96d12435 100644 --- a/net/sched/cls_flower.c +++ b/net/sched/cls_flower.c @@ -234,14 +234,15 @@ static void fl_hw_destroy_filter(struct tcf_proto *tp, struct cls_fl_filter *f) static int fl_hw_replace_filter(struct tcf_proto *tp, struct flow_dissector *dissector, struct fl_flow_key *mask, - struct cls_fl_filter *f) + struct cls_fl_filter *f, + struct netlink_ext_ack *extack) { struct tc_cls_flower_offload cls_flower = {}; struct tcf_block *block = tp->chain->block; bool skip_sw = tc_skip_sw(f->flags); int err; - tc_cls_common_offload_init(&cls_flower.common, tp, NULL); + tc_cls_common_offload_init(&cls_flower.common, tp, extack); cls_flower.command = TC_CLSFLOWER_REPLACE; cls_flower.cookie = (unsigned long) f; cls_flower.dissector = dissector; @@ -939,7 +940,8 @@ static int fl_change(struct net *net, struct sk_buff *in_skb, err = fl_hw_replace_filter(tp, &head->dissector, &mask.key, - fnew); + fnew, + extack); if (err) goto errout_idr; } -- 2.15.1
Powered by blists - more mailing lists