netdev - Re: [Patch net v3] tun: fix a memory leak for tfile->tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <16b82836-7e07-c13c-cd7b-917eaa06d224@redhat.com>
Date:   Tue, 16 Jan 2018 14:00:52 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Dmitry Vyukov <dvyukov@...gle.com>
Subject: Re: [Patch net v3] tun: fix a memory leak for tfile->tx_array



On 2018年01月16日 13:49, Cong Wang wrote:
> On Mon, Jan 15, 2018 at 9:46 PM, Jason Wang <jasowang@...hat.com> wrote:
>>
>> I think then you don't even need the memset trick since we are sure it has
>> been implemented?
> It doesn't look like sk_alloc() zero's the memory of tfile.

Typo, for "implemented" I mean "initialized".

I mean we can leave __tun_detach() as is, and just add the cleanup to 
tun_detach_all(). This is because in both cases, we're sure skb array 
has been initialized before.

Thanks