netdev - Re: [PATCH net-next] net: sched: fix use before alloc of per cpu stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM_iQpXMd91wyv5hiV7J0XeKR-8gWZ5dc7GVka7PmifdtgWePQ@mail.gmail.com>
Date:   Mon, 15 Jan 2018 22:43:25 -0800
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Prashant Bhole <bhole_prashant_q7@....ntt.co.jp>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Daniel Borkmann <daniel@...earbox.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: sched: fix use before alloc of per cpu stats

On Mon, Jan 15, 2018 at 10:33 PM, Prashant Bhole
<bhole_prashant_q7@....ntt.co.jp> wrote:
> Pardon my ignorance, I think it is necessary to forward d59f5ffa59d8 to
> -net. Because previously flags were set during init and checked after init
> to allocate memory. static_flags makes the flags available before init,
> hence we can allocate memory before init.

Oh, right, but we can allocate it unconditionally and free it if not needed
after ->init(). It is not prettier though. ;)

> Sorry, but from your reply I couldn't understand whether we need v2 for
> net-next.
>

I don't think you need to send v2, because the one for -net will be merged
(with a conflict) into -net-next by DaveM.