netdev - Re: [PATCH net-next] l2tp: remove switch block in l2tp_nl_cmd_session

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180117113246.GK1422@alphalink.fr>
Date:   Wed, 17 Jan 2018 12:32:46 +0100
From:   Guillaume Nault <g.nault@...halink.fr>
To:     Lorenzo Bianconi <lorenzo.bianconi@...hat.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, jchapman@...alix.com
Subject: Re: [PATCH net-next] l2tp: remove switch block in
 l2tp_nl_cmd_session_create()

On Wed, Jan 17, 2018 at 11:41:20AM +0100, Lorenzo Bianconi wrote:
> Remove the switch block in l2tp_nl_cmd_session_create() that
> checks pseudowire-specific parameters since just L2TP_PWTYPE_ETH and
> L2TP_PWTYPE_PPP are currently supported and no actual checks are
> performed. Moreover the L2TP_PWTYPE_IP/default case presents a harmless
> issue in error handling (break instead of goto out_tunnel)
> 

Acked-by: Guillaume Nault <g.nault@...halink.fr>