netdev - Re: [PATCH v2 net 1/1] net/tls: Only attach to sockets in ESTABLISHED state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180117.160619.714101917442415808.davem@davemloft.net>
Date:   Wed, 17 Jan 2018 16:06:19 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     ilyal@...lanox.com
Cc:     netdev@...r.kernel.org, davejwatson@...com
Subject: Re: [PATCH v2 net 1/1] net/tls: Only attach to sockets in
 ESTABLISHED state

From: Ilya Lesokhin <ilyal@...lanox.com>
Date: Tue, 16 Jan 2018 15:31:52 +0200

> Calling accept on a TCP socket with a TLS ulp attached results
> in two sockets that share the same ulp context.
> The ulp context is freed while a socket is destroyed, so
> after one of the sockets is released, the second second will
> trigger a use after free when it tries to access the ulp context
> attached to it.
> We restrict the TLS ulp to sockets in ESTABLISHED state
> to prevent the scenario above.
> 
> Fixes: 3c4d7559159b ("tls: kernel TLS support")
> Reported-by: syzbot+904e7cd6c5c741609228@...kaller.appspotmail.com
> Signed-off-by: Ilya Lesokhin <ilyal@...lanox.com>
> ---
> v2: Fix typos

Applied and queued up for -stable, thanks.