lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Jan 2018 11:41:25 +0100 From: Arnd Bergmann <arnd@...db.de> To: Greentime Hu <green.hu@...il.com> Cc: Greentime <greentime@...estech.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linux-arch <linux-arch@...r.kernel.org>, Thomas Gleixner <tglx@...utronix.de>, Jason Cooper <jason@...edaemon.net>, Marc Zyngier <marc.zyngier@....com>, Rob Herring <robh+dt@...nel.org>, Networking <netdev@...r.kernel.org>, Vincent Chen <deanbo422@...il.com>, DTML <devicetree@...r.kernel.org>, Al Viro <viro@...iv.linux.org.uk>, David Howells <dhowells@...hat.com>, Will Deacon <will.deacon@....com>, Daniel Lezcano <daniel.lezcano@...aro.org>, linux-serial@...r.kernel.org, Geert Uytterhoeven <geert.uytterhoeven@...il.com>, Linus Walleij <linus.walleij@...aro.org>, Mark Rutland <mark.rutland@....com>, Greg KH <greg@...ah.com>, Guo Ren <ren_guo@...ky.com>, Randy Dunlap <rdunlap@...radead.org>, David Miller <davem@...emloft.net>, Jonas Bonn <jonas@...thpole.se>, Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>, Stafford Horne <shorne@...il.com>, Vincent Chen <vincentc@...estech.com> Subject: Re: [PATCH v6 24/36] nds32: Loadable modules On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu <green.hu@...il.com> wrote: > From: Greentime Hu <greentime@...estech.com> > > This patch adds support for loadable modules. One detail: You still seem to have both the ELF_REL and ELF_RELA based functions implemented here, you should drop the unused ELF_REL version: > diff --git a/arch/nds32/kernel/module.c b/arch/nds32/kernel/module.c > new file mode 100644 > index 0000000..714a6d6 > --- /dev/null > +++ b/arch/nds32/kernel/module.c > @@ -0,0 +1,286 @@ > +// SPDX-License-Identifier: GPL-2.0 > +// Copyright (C) 2005-2017 Andes Technology Corporation > + > +#include <linux/module.h> > +#include <linux/elf.h> > +#include <linux/vmalloc.h> > + > +#include <asm/pgtable.h> include <linux/moduleloader.h> to catch this. > +int > +apply_relocate(Elf32_Shdr * sechdrs, const char *strtab, > + unsigned int symindex, unsigned int relsec, > + struct module *module) > +{ > + return 0; > +} and drop this. With that change, Acked-by: Arnd Bergmann <arnd@...db.de>
Powered by blists - more mailing lists