netdev - Re: [bpf-next PATCH] samples/bpf: xdp2skb_meta comment explain why pkt-data pointers are invalidated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8fe20e17-5223-b80a-4773-2d7e126c17a9@iogearbox.net>
Date:   Thu, 18 Jan 2018 01:50:32 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Jesper Dangaard Brouer <brouer@...hat.com>,
        Daniel Borkmann <borkmann@...earbox.net>,
        Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [bpf-next PATCH] samples/bpf: xdp2skb_meta comment explain why
 pkt-data pointers are invalidated

On 01/17/2018 11:17 AM, Jesper Dangaard Brouer wrote:
> Improve the 'unknown reason' comment, with an actual explaination of why
> the ctx pkt-data pointers need to be loaded after the helper function
> bpf_xdp_adjust_meta().  Based on the explaination Daniel gave.
> 
> Fixes: 36e04a2d78d9 ("samples/bpf: xdp2skb_meta shows transferring info from XDP to SKB")
> Reported-by: Daniel Borkmann <daniel@...earbox.net>
> Signed-off-by: Jesper Dangaard Brouer <brouer@...hat.com>

Applied to bpf-next, thanks for following up on this, Jesper!