[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1516282911-29198-1-git-send-email-aviadye@mellanox.com>
Date: Thu, 18 Jan 2018 15:41:51 +0200
From: Aviad Yehezkel <aviadye@...lanox.com>
To: steffen.klassert@...unet.com, davem@...emloft.net,
herbert@...dor.apana.org.au, netdev@...r.kernel.org
Cc: Aviad Yehezkel <aviadye@...lanox.com>,
Boris Pismeny <borisp@...lanox.com>
Subject: [PATCH xfrm v1] xfrm: fix error flow in case of add state fails
If add state fails in case of device offload, netdev refcount
will be negative since gc task is attempting to dev_free this state.
This is fixed by putting NULL in state dev field.
Signed-off-by: Aviad Yehezkel <aviadye@...lanox.com>
Signed-off-by: Boris Pismeny <borisp@...lanox.com>
---
net/xfrm/xfrm_device.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/xfrm/xfrm_device.c b/net/xfrm/xfrm_device.c
index fb3f920..cd2b7d3 100644
--- a/net/xfrm/xfrm_device.c
+++ b/net/xfrm/xfrm_device.c
@@ -109,6 +109,7 @@ int xfrm_dev_state_add(struct net *net, struct xfrm_state *x,
err = dev->xfrmdev_ops->xdo_dev_state_add(x);
if (err) {
+ xso->dev = NULL;
dev_put(dev);
return err;
}
--
2.7.4
Powered by blists - more mailing lists