lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Jan 2018 10:38:39 -0500 From: Alexander Aring <aring@...atatu.com> To: Jakub Kicinski <kubakici@...pl> Cc: Jamal Hadi Salim <jhs@...atatu.com>, Cong Wang <xiyou.wangcong@...il.com>, Jiří Pírko <jiri@...nulli.us>, David Miller <davem@...emloft.net>, netdev@...r.kernel.org, kernel@...atatu.com, David Ahern <dsahern@...il.com> Subject: Re: [PATCHv2 net-next 8/8] net: sched: cls_u32: add extack support Hi, On Wed, Jan 17, 2018 at 8:27 PM, Jakub Kicinski <kubakici@...pl> wrote: > On Wed, 17 Jan 2018 17:40:27 -0500, Alexander Aring wrote: >> diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c >> index 8840baa1b9b4..daeac7282387 100644 >> --- a/net/sched/cls_u32.c >> +++ b/net/sched/cls_u32.c >> @@ -524,8 +524,10 @@ static int u32_replace_hw_hnode(struct tcf_proto *tp, struct tc_u_hnode *h, >> offloaded = true; >> } >> >> - if (skip_sw && !offloaded) >> + if (skip_sw && !offloaded) { >> + NL_SET_ERR_MSG(extack, "Failed to offload filter requested with skip sw"); >> return -EINVAL; >> + } >> >> return 0; >> } > > Why did you ignore my comment about using NL_SET_ERR_MSG_MOD? Do you > disagree with it? Sorry, I missed it I will add this. Thanks. - Alex
Powered by blists - more mailing lists