netdev - Re: [PATCH v2] net: ethernet: cavium: Correct Cavium Thunderx nicvf/nicpf modules names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180118181857.GA4207@localhost.localdomain>
Date:   Thu, 18 Jan 2018 10:18:57 -0800
From:   Vadim Lomovtsev <Vadim.Lomovtsev@...iumnetworks.com>
To:     sgoutham@...ium.com, rric@...nel.org,
        linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Vadim Lomovtsev <Vadim.Lomovtsev@...ium.com>,
        Dean Nelson <dnelson@...hat.com>
Subject: Re: [PATCH v2] net: ethernet: cavium: Correct Cavium Thunderx
 nicvf/nicpf modules names


Self NACK here: modules names has to contain dashes instead
of underscores, as it defined at sources (or update modules
DRV_NAME definitions whithin the source files with underscores).
Shame on me.

Vadim

On Thu, Jan 18, 2018 at 07:53:09AM -0800, Vadim Lomovtsev wrote:
> From: Vadim Lomovtsev <Vadim.Lomovtsev@...ium.com>
> 
> It was found that ethtool provides unexisting module name while
> it queries the specified network device for associated driver
> information.
> 
> This patch is to correct Cavium CN88xx Thunder nicvf/nicpf modules
> names 'nicvf' to 'thunder_nicvf' and 'nicpf' to 'thunder_nicpf'.
> 
> Signed-off-by: Dean Nelson <dnelson@...hat.com>
> Signed-off-by: Vadim Lomovtsev <Vadim.Lomovtsev@...ium.com>
> ---
>  drivers/net/ethernet/cavium/thunder/Makefile | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/cavium/thunder/Makefile b/drivers/net/ethernet/cavium/thunder/Makefile
> index 6b4d4add7353..f5642337d0fe 100644
> --- a/drivers/net/ethernet/cavium/thunder/Makefile
> +++ b/drivers/net/ethernet/cavium/thunder/Makefile
> @@ -4,9 +4,9 @@
>  
>  obj-$(CONFIG_THUNDER_NIC_RGX) += thunder_xcv.o
>  obj-$(CONFIG_THUNDER_NIC_BGX) += thunder_bgx.o
> -obj-$(CONFIG_THUNDER_NIC_PF) += nicpf.o
> -obj-$(CONFIG_THUNDER_NIC_VF) += nicvf.o
> +obj-$(CONFIG_THUNDER_NIC_PF) += thunder_nicpf.o
> +obj-$(CONFIG_THUNDER_NIC_VF) += thunder_nicvf.o
>  
> -nicpf-y := nic_main.o
> -nicvf-y := nicvf_main.o nicvf_queues.o
> -nicvf-y += nicvf_ethtool.o
> +thunder_nicpf-y := nic_main.o
> +thunder_nicvf-y := nicvf_main.o nicvf_queues.o
> +thunder_nicvf-y += nicvf_ethtool.o
> -- 
> 2.14.3
>