netdev - Re: [PATCH net] flow_dissector: properly cap thoff field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180118.162626.1790594555030528090.davem@davemloft.net>
Date:   Thu, 18 Jan 2018 16:26:26 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org, willemb@...gle.com
Subject: Re: [PATCH net] flow_dissector: properly cap thoff field

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 17 Jan 2018 14:21:13 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> syzbot reported yet another crash [1] that is caused by
> insufficient validation of DODGY packets.
> 
> Two bugs are happening here to trigger the crash.
> 
> 1) Flow dissection leaves with incorrect thoff field.
> 
> 2) skb_probe_transport_header() sets transport header to this invalid
> thoff, even if pointing after skb valid data.
> 
> 3) qdisc_pkt_len_init() reads out-of-bound data because it
> trusts tcp_hdrlen(skb)  
> 
> Possible fixes :
> 
> - Full flow dissector validation before injecting bad DODGY packets in
> the stack.
>  This approach was attempted here : https://patchwork.ozlabs.org/patch/
> 861874/
> 
> - Have more robust functions in the core.
>   This might be needed anyway for stable versions.
> 
> This patch fixes the flow dissection issue.
> 
> [1]
 ...
> Fixes: 34fad54c2537 ("net: __skb_flow_dissect() must cap its return value")
> Fixes: a6e544b0a88b ("flow_dissector: Jump to exit code in __skb_flow_dissect")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Willem de Bruijn <willemb@...gle.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>

Applied and queued up for -stable, thanks Eric.