netdev - Re: [pull request bpf-next 0/8] bpf: offload: array maps, reporting and test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8b8dc74c-4d2c-abf1-fc35-fa72ae4e3c61@iogearbox.net>
Date:   Thu, 18 Jan 2018 23:09:16 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        alexei.starovoitov@...il.com
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com, tehnerd@...com
Subject: Re: [pull request bpf-next 0/8] bpf: offload: array maps, reporting
 and test

On 01/18/2018 04:13 AM, Jakub Kicinski wrote:
> Hi!
> 
> This set bring in the rest of map offload code held up by urgent
> fixes and improvements to the BPF arrays.
> 
> The first 3 patches take care of array map offload, similarly to
> hash maps the attribute validation is split out to a separate map
> op, and used for both offloaded and non-offloaded case (allocation
> only happens if map is on the host).  Offload support comes down
> to allowing this map type through the offload check in the core.
> NFP driver also rejects the delete operation in case of array maps.
> 
> Subsequent patches add reporting of target device in a very similar
> way target device of programs is reported (ifindex+netns dev/ino).
> Netdevsim is extended with a trivial map implementation allowing us
> to test the offload in test_offload.py.
> 
> Last patch adds a small busy wait to NFP map IO, this improves the
> response times which is especially useful for map dumps.

Looks good to me as well, applied to bpf-next, thanks Jakub!