netdev - Re: [RFC PATCH net-next 02/12] selftests: forwarding: Add a test for FDB learning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9e1bfed9-34a3-5810-230e-0bef75a43fb9@gmail.com>
Date:   Wed, 17 Jan 2018 16:15:04 -0800
From:   David Ahern <dsahern@...il.com>
To:     Jiri Pirko <jiri@...nulli.us>,
        Roopa Prabhu <roopa@...ulusnetworks.com>
Cc:     Ido Schimmel <idosch@...lanox.com>, netdev@...r.kernel.org,
        linux-kselftest@...r.kernel.org,
        David Miller <davem@...emloft.net>, shuah@...nel.org,
        Nikolay Aleksandrov <nikolay@...ulusnetworks.com>,
        Andy Gospodarek <andy@...yhouse.net>,
        Jiri Pirko <jiri@...lanox.com>, mlxsw <mlxsw@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>, tariqt@...lanox.com,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Lucas Bates <lucasb@...atatu.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
        Andrew Lunn <andrew@...n.ch>, jakub.kicinski@...ronome.com,
        Simon Horman <simon.horman@...ronome.com>
Subject: Re: [RFC PATCH net-next 02/12] selftests: forwarding: Add a test for
 FDB learning

On 1/17/18 3:31 PM, Jiri Pirko wrote:
> Wed, Jan 17, 2018 at 11:59:10PM CET, roopa@...ulusnetworks.com wrote:
>> On Wed, Jan 17, 2018 at 2:46 PM, Roopa Prabhu <roopa@...ulusnetworks.com> wrote:
>>> On Wed, Jan 17, 2018 at 1:01 PM, Jiri Pirko <jiri@...nulli.us> wrote:
>>>> Wed, Jan 17, 2018 at 09:48:54PM CET, dsahern@...il.com wrote:
>>>>> On 1/15/18 11:18 AM, Ido Schimmel wrote:
>>>>>> diff --git a/tools/testing/selftests/forwarding/lib.sh b/tools/testing/selftests/forwarding/lib.sh
>>>>>> index bb423371f4de..264bf0af4c4d 100644
>>>>>> --- a/tools/testing/selftests/forwarding/lib.sh
>>>>>> +++ b/tools/testing/selftests/forwarding/lib.sh
>>>>>> @@ -22,6 +22,11 @@ if [[ ! -x "$(command -v jq)" ]]; then
>>>>>>      exit 0
>>>>>>  fi
>>>>>>
>>>>>> +if [[ ! -x "$(command -v mausezahn)" ]]; then
>>>>>> +    echo "SKIP: mausezahn not installed"
>>>>>> +    exit 0
>>>>>> +fi
>>>>>> +
>>>>>
>>>>> The checks are good, but hitting a collision with this one:
>>>>> $   ./router.sh
>>>>> SKIP: mausezahn not installed
>>>>>
>>>>> For debian, it is mz not mausezahn.
>>>>
>>>> That is weird. If you look at the sources, the binary name is
>>>> "mausezahn". Looks like debian is doing some renaming :/
>>>>
>>>
>>> I have seen/used both versions. Debian packages from some old upstream
>>> source which calls it mz.
>>> https://packages.debian.org/sid/main/mz
>>>
>>> I have used latest mz (with ipv6 support etc) from netsniff-ng which
>>> builds it as mausezahn.
>>
>>
>> actually Debian also builds
>> https://packages.debian.org/sid/netsniff-ng and installs 'mausezahn'
>>
>> so you might have to check and use which exists... (mausezahn overriding mz).
> 
> I believe we can stick with mausezahn, since it is apparently
> available on Debian too.
> 

How about the attached - make ping, ping6 and mz variables? Default to
ping and mausezahn but let users update that name if necessary. Comments
in the sample config to the effect need to be added to help users.

View attachment "selftests.patch" of type "text/plain" (7725 bytes)