[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180118075136.GA2290@nanopsycho>
Date: Thu, 18 Jan 2018 08:51:36 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Ido Schimmel <idosch@...sch.org>
Cc: David Ahern <dsahern@...il.com>,
Roopa Prabhu <roopa@...ulusnetworks.com>,
Ido Schimmel <idosch@...lanox.com>, netdev@...r.kernel.org,
linux-kselftest@...r.kernel.org,
David Miller <davem@...emloft.net>, shuah@...nel.org,
Nikolay Aleksandrov <nikolay@...ulusnetworks.com>,
Andy Gospodarek <andy@...yhouse.net>,
Jiri Pirko <jiri@...lanox.com>, mlxsw <mlxsw@...lanox.com>,
Saeed Mahameed <saeedm@...lanox.com>, tariqt@...lanox.com,
Jamal Hadi Salim <jhs@...atatu.com>,
Lucas Bates <lucasb@...atatu.com>,
Florian Fainelli <f.fainelli@...il.com>,
Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
Andrew Lunn <andrew@...n.ch>, jakub.kicinski@...ronome.com,
Simon Horman <simon.horman@...ronome.com>
Subject: Re: [RFC PATCH net-next 02/12] selftests: forwarding: Add a test for
FDB learning
Thu, Jan 18, 2018 at 08:16:54AM CET, idosch@...sch.org wrote:
>On Wed, Jan 17, 2018 at 04:15:04PM -0800, David Ahern wrote:
>> How about the attached - make ping, ping6 and mz variables? Default to
>> ping and mausezahn but let users update that name if necessary. Comments
>> in the sample config to the effect need to be added to help users.
>
>Yes, looks good to me. Will include the change in the next version.
Ido, please keep in mind that the script should run without the config
file. So the defaults should be in lib.sh.
Thanks!
Powered by blists - more mailing lists