netdev - Re: [net-next 1/1] tipc: fix race between poll() and setsockopt()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180119.151236.189272942434998868.davem@davemloft.net>
Date:   Fri, 19 Jan 2018 15:12:36 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jon.maloy@...csson.com
Cc:     netdev@...r.kernel.org,
        mohan.krishna.ghanta.krishnamurthy@...csson.com,
        tung.q.nguyen@...tech.com.au, hoang.h.le@...tech.com.au,
        canh.d.luu@...tech.com.au, ying.xue@...driver.com,
        tipc-discussion@...ts.sourceforge.net
Subject: Re: [net-next 1/1] tipc: fix race between poll() and setsockopt()

From: Jon Maloy <jon.maloy@...csson.com>
Date: Wed, 17 Jan 2018 16:42:46 +0100

> Letting tipc_poll() dereference a socket's pointer to struct tipc_group
> entails a race risk, as the group item may be deleted in a concurrent
> tipc_sk_join() or tipc_sk_leave() thread.
> 
> We now move the 'open' flag in struct tipc_group to struct tipc_sock,
> and let the former retain only a pointer to the moved field. This will
> eliminate the race risk.
> 
> Reported-by: syzbot+799dafde0286795858ac@...kaller.appspotmail.com
> Signed-off-by: Jon Maloy <jon.maloy@...csson.com>

Applied, thanks Jon.