netdev - Re: [patch net] mlxsw: spectrum_router: Free LPM tree upon failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 18 Jan 2018 20:57:17 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jiri@...nulli.us
Cc:     netdev@...r.kernel.org, idosch@...lanox.com, mlxsw@...lanox.com
Subject: Re: [patch net] mlxsw: spectrum_router: Free LPM tree upon failure

From: Jiri Pirko <jiri@...nulli.us>
Date: Thu, 18 Jan 2018 15:42:10 +0100

> From: Ido Schimmel <idosch@...lanox.com>
> 
> When a new LPM tree is created, we try to replace the trees in the
> existing virtual routers with it. If we fail, the tree needs to be
> freed.
> 
> Currently, this does not happen in the unlikely case where we fail to
> bind the tree to the first virtual router, since its reference count
> never transitions from 1 to 0.
> 
> Fix that by taking a reference before binding the tree.
> 
> Fixes: fc922bb0dd94 ("mlxsw: spectrum_router: Use one LPM tree for all virtual routers")
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>

Applied, thanks Jiri.