netdev - Re: [PATCH iproute2] devlink: Ignore unknown attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <695fecfe-c45e-4a83-cee8-0476ee56d422@gmail.com>
Date:   Thu, 18 Jan 2018 20:42:44 -0800
From:   David Ahern <dsahern@...il.com>
To:     Arkadi Sharshevsky <arkadis@...lanox.com>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, stephen@...workplumber.org, mlxsw@...lanox.com
Subject: Re: [PATCH iproute2] devlink: Ignore unknown attributes

On 1/17/18 5:28 AM, Arkadi Sharshevsky wrote:
> In case of extending the UAPI old packages would break.
> 
> Signed-off-by: Arkadi Sharshevsky <arkadis@...lanox.com>
> ---
>  devlink/devlink.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/devlink/devlink.c b/devlink/devlink.c
> index 39cda06..c9d1838 100644
> --- a/devlink/devlink.c
> +++ b/devlink/devlink.c
> @@ -343,7 +343,7 @@ static int attr_cb(const struct nlattr *attr, void *data)
>  	int type;
>  
>  	if (mnl_attr_type_valid(attr, DEVLINK_ATTR_MAX) < 0)
> -		return MNL_CB_ERROR;
> +		return MNL_CB_OK;
>  
>  	type = mnl_attr_get_type(attr);
>  	if (mnl_attr_validate(attr, devlink_policy[type]) < 0)
> 

What's the point of calling mnl_attr_type_valid if you disregard a
failure? you might as well not call mnl_attr_type_valid at all.