netdev - Re: [bpf-next PATCH] samples/bpf: xdp_monitor include cpumap tracepoints in monitoring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cb1de586-5e69-1fca-08dc-826213af5e4d@iogearbox.net>
Date:   Sat, 20 Jan 2018 02:34:53 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Jesper Dangaard Brouer <brouer@...hat.com>,
        Daniel Borkmann <borkmann@...earbox.net>,
        Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc:     victor@...iniac.net, netdev@...r.kernel.org, eric@...it.org,
        petermanev@...il.com
Subject: Re: [bpf-next PATCH] samples/bpf: xdp_monitor include cpumap
 tracepoints in monitoring

On 01/19/2018 05:15 PM, Jesper Dangaard Brouer wrote:
> The xdp_redirect_cpu sample have some "builtin" monitoring of the
> tracepoints for xdp_cpumap_*, but it is practical to have an external
> tool that can monitor these transpoint as an easy way to troubleshoot
> an application using XDP + cpumap.
> 
> Specifically I need such external tool when working on Suricata and
> XDP cpumap redirect. Extend the xdp_monitor tool sample with
> monitoring of these xdp_cpumap_* tracepoints.  Model the output format
> like xdp_redirect_cpu.
> 
> Given I needed to handle per CPU decoding for cpumap, this patch also
> add per CPU info on the existing monitor events.  This resembles part
> of the builtin monitoring output from sample xdp_rxq_info.  Thus, also
> covering part of that sample in an external monitoring tool.
> 
> Performance wise, the cpumap tracepoints uses bulking, which cause
> them to have very little overhead.  Thus, they are enabled by default.
> 
> Signed-off-by: Jesper Dangaard Brouer <brouer@...hat.com>

Applied to bpf-next, thanks Jesper!