netdev - Re: [PATCH bpf-next 0/4] libbpf: add XDP binding support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180120022753.psuzgzmxqaubh5t3@ast-mbp>
Date:   Fri, 19 Jan 2018 18:27:55 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Daniel Borkmann <daniel@...earbox.net>
Cc:     Eric Leblond <eric@...it.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH bpf-next 0/4] libbpf: add XDP binding support

On Sat, Jan 20, 2018 at 03:00:37AM +0100, Daniel Borkmann wrote:
> On 01/19/2018 12:43 AM, Eric Leblond wrote:
> > Hello,
> > 
> > This patchset rebases the libbpf code on latest bpf-next code and addresses
> > remarks by Daniel.
> 
> Ok, I think it's a good start. We should later on clean up the
> netlink handling code a bit, but that's all internal and can be
> done in a second step. Applied to bpf-next, thanks Eric.

Sorry, Eric, Daniel.
I had to revert this patch set. It breaks build on systems
where headers are not the most recent.

Since libbpf is used by perf it has to be built cleanly on centos7 at least.

The errors I got:
bpf.c: In function ‘bpf_set_link_xdp_fd’:
bpf.c:456:23: error: ‘SOL_NETLINK’ undeclared (first use in this function)
  if (setsockopt(sock, SOL_NETLINK, NETLINK_EXT_ACK,
                       ^~~~~~~~~~~
bpf.c:456:23: note: each undeclared identifier is reported only once for each function it appears in
bpf.c:456:36: error: ‘NETLINK_EXT_ACK’ undeclared (first use in this function)
  if (setsockopt(sock, SOL_NETLINK, NETLINK_EXT_ACK,
                                    ^~~~~~~~~~~~~~~
nlattr.c: In function ‘nla_dump_errormsg’:
nlattr.c:152:34: error: ‘NLMSGERR_ATTR_MAX’ undeclared (first use in this function)
  struct nla_policy extack_policy[NLMSGERR_ATTR_MAX + 1] = {