netdev - Re: [PATCH net] net/mlx5e: Fix fixpoint divide exception in mlx5e_am_stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d724643d-5895-bb21-6ec7-af234477f4bd@cogentembedded.com>
Date:   Sat, 20 Jan 2018 11:10:10 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Saeed Mahameed <saeedm@...lanox.com>,
        "David S. Miller" <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, Talat Batheesh <talatb@...lanox.com>
Subject: Re: [PATCH net] net/mlx5e: Fix fixpoint divide exception in
 mlx5e_am_stats_compare

Hello!

On 1/19/2018 11:10 PM, Saeed Mahameed wrote:

> From: Talat Batheesh <talatb@...lanox.com>
> 
> Helmut reported a bug about devision by zero while

    Division.

> running traffic and doing physical cable pull test.
> 
> When the cable unplugged the ppms become zero, so when
> dividing the current ppms by the previous ppms in the

    You got it right the on the 2nd time. :-)

> next dim iteration there is devision by zero.
> 
> This patch prevent this division for both ppms and epms.
> 
> Fixes: c3164d2fc48f ("net/mlx5e: Added BW check for DIM decision mechanism")
> Reported-by: Helmut Grauer <helmut.grauer@...ibm.com>
> Signed-off-by: Talat Batheesh <talatb@...lanox.com>
> Signed-off-by: Saeed Mahameed <saeedm@...lanox.com>
[...]

MBR, Sergei