netdev - Re: [patch iproute2 net-next v11 3/4] tc: introduce support for block-handle for filter operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180120093716.GE2147@nanopsycho.orion>
Date:   Sat, 20 Jan 2018 10:37:16 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     David Ahern <dsahern@...il.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, jhs@...atatu.com,
        xiyou.wangcong@...il.com, mlxsw@...lanox.com, andrew@...n.ch,
        vivien.didelot@...oirfairelinux.com, f.fainelli@...il.com,
        michael.chan@...adcom.com, ganeshgr@...lsio.com,
        saeedm@...lanox.com, matanb@...lanox.com, leonro@...lanox.com,
        idosch@...lanox.com, jakub.kicinski@...ronome.com,
        simon.horman@...ronome.com, pieter.jansenvanvuuren@...ronome.com,
        john.hurley@...ronome.com, alexander.h.duyck@...el.com,
        ogerlitz@...lanox.com, john.fastabend@...il.com,
        daniel@...earbox.net
Subject: Re: [patch iproute2 net-next v11 3/4] tc: introduce support for
 block-handle for filter operations

Fri, Jan 19, 2018 at 09:51:22PM CET, dsahern@...il.com wrote:
>On 1/17/18 2:48 AM, Jiri Pirko wrote:
>> @@ -89,7 +93,21 @@ static int tc_filter_modify(int cmd, unsigned int flags, int argc, char **argv,
>>  			NEXT_ARG();
>>  			if (d[0])
>>  				duparg("dev", *argv);
>> +			if (block_index) {
>> +				fprintf(stderr, "Error: \"dev\" cannot be used in the same time as \"block\"\n");
>
>'in the same time' does not sound right. something like: 'dev and block
>are mutually exlusive'

ack


>
>> +				return -1;
>> +			}
>>  			strncpy(d, *argv, sizeof(d)-1);
>> +		} else if (matches(*argv, "block") == 0) {
>> +			NEXT_ARG();
>> +			if (block_index)
>> +				duparg("block", *argv);
>> +			if (d[0]) {
>> +				fprintf(stderr, "Error: \"block\" cannot be used in the same time as \"dev\"\n");
>
>same here. Correct the ones below as well.

ack


>
>
>> +				return -1;
>> +			}
>> +			if (get_u32(&block_index, *argv, 0) || !block_index)
>> +				invarg("invalid block index value", *argv);