netdev - Re: [PATCH net-next] nfp: flower: prioritize stats updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180121.181000.1888376651546300697.davem@davemloft.net>
Date:   Sun, 21 Jan 2018 18:10:00 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     oss-drivers@...ronome.com, netdev@...r.kernel.org,
        pieter.jansenvanvuuren@...ronome.com
Subject: Re: [PATCH net-next] nfp: flower: prioritize stats updates

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Fri, 19 Jan 2018 17:54:08 -0800

> From: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@...ronome.com>
> 
> Previously it was possible to interrupt processing stats updates because
> they were handled in a work queue. Interrupting the stats updates could
> lead to a situation where we backup the control message queue. This patch
> moves the stats update processing out of the work queue to be processed as
> soon as hardware sends a request.
> 
> Reported-by: Louis Peens <louis.peens@...ronome.com>
> Signed-off-by: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@...ronome.com>
> Reviewed-by: Dirk van der Merwe <dirk.vandermerwe@...ronome.com>
> Reviewed-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Applied, thanks Jakub.

Just a reminder that it really makes things more difficult that one
can't just go:

	make drivers/net/ethernet/netronome/nfp/flower/cmsg.o

to test a specific NFP object build like one can with pretty much the
rest of the entire kernel tree.