netdev - Re: [PATCH iproute2-next 1/2] ip/tunnel: Be consistent when printing tunnel collect metadata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180122175841.71400890@redhat.com>
Date:   Mon, 22 Jan 2018 17:58:41 +0100
From:   Jiri Benc <jbenc@...hat.com>
To:     Serhey Popovych <serhe.popovych@...il.com>
Cc:     netdev@...r.kernel.org, u9012063@...il.com,
        julien@...ulusnetworks.com
Subject: Re: [PATCH iproute2-next 1/2] ip/tunnel: Be consistent when
 printing tunnel collect metadata

On Mon, 22 Jan 2018 18:46:53 +0200, Serhey Popovych wrote:
> +	if (tb[IFLA_GRE_COLLECT_METADATA]) {
> +		print_bool(PRINT_ANY, "collect_metadata", "external", true);
> +		return;
> +	}

Nacked-by: Jiri Benc <jbenc@...hat.com>

Don't ever use "collect_metadata" for anything visible to the user.

collect_metadata is a *horrible* name. It describes the internal
implementation of the lwtunneling in the kernel and provides zero
explanation to the user about what's that feature good for.

The netlink attribute should have never had such name but it's uAPI and
we have to live with it. But there's no reason to expose this to the
user.

Stick with the "external" name. It explains what it is about: instead of
the traffic being controlled by the tunnel internal logic (or tunnel
control plane, if you want), an external logic needs to be attached to
the tunnel in order for the tunneling to work.

 Jiri