netdev - Re: [PATCH net] 8139too: revisit napi_complete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1516647828.3478.11.camel@gmail.com>
Date:   Mon, 22 Jan 2018 11:03:48 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     whiteheadm@....org
Cc:     ville.syrjala@...ux.intel.com, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net] 8139too: revisit napi_complete_done() usage

On Mon, 2018-01-22 at 12:27 -0500, tedheadster wrote:
> On Mon, Sep 18, 2017 at 11:57 PM, David Miller <davem@...emloft.net> wrote:
> > From: Eric Dumazet <eric.dumazet@...il.com>
> > Date: Mon, 18 Sep 2017 13:03:43 -0700
> > 
> > > From: Eric Dumazet <edumazet@...gle.com>
> > > 
> > > It seems we have to be more careful in napi_complete_done()
> > > use. This patch is not a revert, as it seems we can
> > > avoid bug that Ville reported by moving the napi_complete_done()
> > > test in the spinlock section.
> > > 
> > > Many thanks to Ville for detective work and all tests.
> > > 
> > > Fixes: 617f01211baf ("8139too: use napi_complete_done()")
> > > Reported-by: Ville Syrjälä <ville.syrjala@...ux.intel.com>
> > > Tested-by: Ville Syrjälä <ville.syrjala@...ux.intel.com>
> > 
> > Applied and queued up for -stable.
> 
> Eric,
>   sorry to bring up this old thread, but I had a question. Do we have
> to surround most usage of napi_complete_done() with a spinlock, or was
> this problem restricted to just the 8139too driver?


I am not aware of any other NIC driver having a problem there.