netdev - Re: [PATCH net] rds: tcp: compute m_ack_seq as offset from ->write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180122.154408.1214672865084237274.davem@davemloft.net>
Date:   Mon, 22 Jan 2018 15:44:08 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     sowmini.varadhan@...cle.com
Cc:     netdev@...r.kernel.org, santosh.shilimkar@...cle.com
Subject: Re: [PATCH net] rds: tcp: compute m_ack_seq as offset from
 ->write_seq

From: Sowmini Varadhan <sowmini.varadhan@...cle.com>
Date: Thu, 18 Jan 2018 13:11:07 -0800

> rds-tcp uses m_ack_seq to track the tcp ack# that indicates
> that the peer has received a rds_message. The m_ack_seq is
> used in rds_tcp_is_acked() to figure out when it is safe to
> drop the rds_message from the RDS retransmit queue.
> 
> The m_ack_seq must be calculated as an offset from the right 
> edge of the in-flight tcp buffer, i.e., it should be based on 
> the ->write_seq, not the ->snd_nxt.
> 
> Signed-off-by: Sowmini Varadhan <sowmini.varadhan@...cle.com>

Applied, thanks Sowmini.