netdev - Re: [PATCH net v3] gso: validate gso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180122.160223.56363029606360667.davem@davemloft.net>
Date:   Mon, 22 Jan 2018 16:02:23 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     willemdebruijn.kernel@...il.com
Cc:     netdev@...r.kernel.org, edumazet@...gle.com, jasowang@...hat.com,
        tom@...bertland.com, herbert@...dor.apana.org.au,
        willemb@...gle.com
Subject: Re: [PATCH net v3] gso: validate gso_type in GSO handlers

From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Date: Fri, 19 Jan 2018 09:29:18 -0500

> From: Willem de Bruijn <willemb@...gle.com>
> 
> Validate gso_type during segmentation as SKB_GSO_DODGY sources
> may pass packets where the gso_type does not match the contents.
> 
> Syzkaller was able to enter the SCTP gso handler with a packet of
> gso_type SKB_GSO_TCPV4.
> 
> On entry of transport layer gso handlers, verify that the gso_type
> matches the transport protocol.
> 
> Fixes: 90017accff61 ("sctp: Add GSO support")
> Link: http://lkml.kernel.org/r/<001a1137452496ffc305617e5fe0@...gle.com>
> Reported-by: syzbot+fee64147a25aecd48055@...kaller.appspotmail.com
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>
> 
> ---
> Similar checks existed until removed in commit 5c7cdf339af5 ("gso:
> Remove arbitrary checks for unsupported GSO"). But those were limited
> to the TSO path, not software GSO. I believe that this issue goes
> back further, hence the Fixes at the first user of virtio_net_hdr.

Applied and queued up for -stable, thanks Willem.