netdev - Re: [PATCH] net: igmp: fix source address check for IGMPv3 reports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180122.161758.859663134125125839.davem@davemloft.net>
Date:   Mon, 22 Jan 2018 16:17:58 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     nbd@....name
Cc:     netdev@...r.kernel.org, cernekee@...omium.org,
        s.gottschall@...wrt.com
Subject: Re: [PATCH] net: igmp: fix source address check for IGMPv3 reports

From: Felix Fietkau <nbd@....name>
Date: Fri, 19 Jan 2018 11:50:46 +0100

> Commit "net: igmp: Use correct source address on IGMPv3 reports"
> introduced a check to validate the source address of locally generated
> IGMPv3 packets.
> Instead of checking the local interface address directly, it uses
> inet_ifa_match(fl4->saddr, ifa), which checks if the address is on the
> local subnet (or equal to the point-to-point address if used).
> 
> This breaks for point-to-point interfaces, so check against
> ifa->ifa_local directly.
> 
> Cc: Kevin Cernekee <cernekee@...omium.org>
> Fixes: a46182b00290 ("net: igmp: Use correct source address on IGMPv3 reports")
> Reported-by: Sebastian Gottschall <s.gottschall@...wrt.com>
> Signed-off-by: Felix Fietkau <nbd@....name>

Applied, thanks.