netdev - Re: [PATCH net] be2net: restore properly promisc mode after queues reconfiguration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180122.162315.2222855895386712596.davem@davemloft.net>
Date:   Mon, 22 Jan 2018 16:23:15 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     cera@...a.cz
Cc:     netdev@...r.kernel.org, sathya.perla@...adcom.com,
        ajit.khaparde@...adcom.com, sriharsha.basavapatna@...adcom.com,
        somnath.kotur@...adcom.com
Subject: Re: [PATCH net] be2net: restore properly promisc mode after queues
 reconfiguration

From: Ivan Vecera <cera@...a.cz>
Date: Fri, 19 Jan 2018 20:23:50 +0100

> The commit 622190669403 ("be2net: Request RSS capability of Rx interface
> depending on number of Rx rings") modified be_update_queues() so the
> IFACE (HW representation of the netdevice) is destroyed and then
> re-created. This causes a regression because potential promiscuous mode
> is not restored properly during be_open() because the driver thinks
> that the HW has promiscuous mode already enabled.
> 
> Note that Lancer is not affected by this bug because RX-filter flags are
> disabled during be_close() for this chipset.
> 
> Cc: Sathya Perla <sathya.perla@...adcom.com>
> Cc: Ajit Khaparde <ajit.khaparde@...adcom.com>
> Cc: Sriharsha Basavapatna <sriharsha.basavapatna@...adcom.com>
> Cc: Somnath Kotur <somnath.kotur@...adcom.com>
> 
> Fixes: 622190669403 ("be2net: Request RSS capability of Rx interface depending on number of Rx rings")
> Signed-off-by: Ivan Vecera <ivecera@...hat.com>

Applied and queued up for -stable, thank you.