netdev - Re: [PATCH net] tls: Correct length of scatterlist in tls_sw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180122.162702.159233205962084742.davem@davemloft.net>
Date:   Mon, 22 Jan 2018 16:27:02 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     davejwatson@...com
Cc:     netdev@...r.kernel.org, ilyal@...lanox.com, borisp@...lanox.com,
        aviadye@...lanox.com
Subject: Re: [PATCH net] tls: Correct length of scatterlist in
 tls_sw_sendpage

From: Dave Watson <davejwatson@...com>
Date: Fri, 19 Jan 2018 12:30:13 -0800

> The scatterlist is reused by both sendmsg and sendfile.
> If a sendmsg of smaller number of pages is followed by a sendfile
> of larger number of pages, the scatterlist may be too short, resulting
> in a crash in gcm_encrypt.
> 
> Add sg_unmark_end to make the list the correct length.
> 
> tls_sw_sendmsg already calls sg_unmark_end correctly when it allocates
> memory in alloc_sg, or in zerocopy_from_iter.
> 
> Signed-off-by: Dave Watson <davejwatson@...com>

Applied, thanks Dave.