netdev - Re: [PATCH net-next] nfp: fix fw dump handling of absolute rtsym size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180123.103052.2237069996431058068.davem@davemloft.net>
Date:   Tue, 23 Jan 2018 10:30:52 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com,
        carl.heymann@...ronome.com
Subject: Re: [PATCH net-next] nfp: fix fw dump handling of absolute rtsym
 size

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Mon, 22 Jan 2018 17:29:43 -0800

> From: Carl Heymann <carl.heymann@...ronome.com>
> 
> Fix bug that causes _absolute_ rtsym sizes of > 8 bytes (as per symbol
> table) to result in incorrect space used during a TLV-based debug dump.
> 
> Detail: The size calculation stage calculates the correct size (size of
> the rtsym address field == 8), while the dump uses the size in the table
> to calculate the TLV size to reserve. Symbols with size <= 8 are handled
> OK due to aligning sizes to 8, but including any absolute symbol with
> listed size > 8 leads to an ENOSPC error during the dump.
> 
> Fixes: da762863edd9 ("nfp: fix absolute rtsym handling in debug dump")
> Signed-off-by: Carl Heymann <carl.heymann@...ronome.com>
> Reviewed-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Applied, thanks.