netdev - Re: [PATCH] net: igmp: fix source address check for IGMPv3 reports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180123.111801.372375936706492429.davem@davemloft.net>
Date:   Tue, 23 Jan 2018 11:18:01 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     nbd@....name
Cc:     netdev@...r.kernel.org, cernekee@...omium.org,
        s.gottschall@...wrt.com
Subject: Re: [PATCH] net: igmp: fix source address check for IGMPv3 reports

From: Felix Fietkau <nbd@....name>
Date: Tue, 23 Jan 2018 10:48:59 +0100

> On 2018-01-22 22:17, David Miller wrote:
>> From: Felix Fietkau <nbd@....name>
>> Date: Fri, 19 Jan 2018 11:50:46 +0100
>> 
>>> Commit "net: igmp: Use correct source address on IGMPv3 reports"
>>> introduced a check to validate the source address of locally generated
>>> IGMPv3 packets.
>>> Instead of checking the local interface address directly, it uses
>>> inet_ifa_match(fl4->saddr, ifa), which checks if the address is on the
>>> local subnet (or equal to the point-to-point address if used).
>>> 
>>> This breaks for point-to-point interfaces, so check against
>>> ifa->ifa_local directly.
>>> 
>>> Cc: Kevin Cernekee <cernekee@...omium.org>
>>> Fixes: a46182b00290 ("net: igmp: Use correct source address on IGMPv3 reports")
>>> Reported-by: Sebastian Gottschall <s.gottschall@...wrt.com>
>>> Signed-off-by: Felix Fietkau <nbd@....name>
>> 
>> Applied, thanks.
> Thanks. Please queue it up for stable as well, since the commit fixed by
> this patch has already made it to stable kernels.

I did, thank you.