netdev - Re: [PATCH] net: ipv6: ndisc: fix bool assignment in ndisc_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180123.112844.1256276359022440138.davem@davemloft.net>
Date:   Tue, 23 Jan 2018 11:28:44 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     garsilva@...eddedor.com
Cc:     kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ipv6: ndisc: fix bool assignment in ndisc_send_na

From: "Gustavo A. R. Silva" <garsilva@...eddedor.com>
Date: Tue, 23 Jan 2018 09:21:00 -0600

> 
> Quoting David Miller <davem@...emloft.net>:
> 
>> From: "Gustavo A. R. Silva" <garsilva@...eddedor.com>
>> Date: Mon, 22 Jan 2018 16:22:13 -0600
>>
>>> Assign true or false to boolean variables instead of an integer value.
>>>
>>> This issue was detected with the help of Coccinelle.
>>>
>>> Fixes: 1cb3fe513f62 ("ndisc: Break down ndisc_build_skb() and build
>>> message directly.")
>>> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
>>
>> Please don't use the word "fix".
>>
>> '0' is the same as 'false', it's just that the latter is more
>> consistent type wise.
>>
> 
> So "Use true and false for boolean value" would be a better subject?

Yes.