netdev - Re: [PATCH] net: Make synchronize_net() be expedited only when it's really need

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iL=MGSUhjfR-WgCS2N3FE0CEPpUfKSUOCTpjT4dnL7M0w@mail.gmail.com>
Date:   Tue, 23 Jan 2018 08:58:13 -0800
From:   Eric Dumazet <edumazet@...gle.com>
To:     Kirill Tkhai <ktkhai@...tuozzo.com>
Cc:     Eric Dumazet <eric.dumazet@...il.com>,
        netdev <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        David Ahern <dsahern@...il.com>,
        Florian Westphal <fw@...len.de>,
        Xin Long <lucien.xin@...il.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        mschiffer@...verse-factory.net, jakub.kicinski@...ronome.com,
        Vladislav Yasevich <vyasevich@...il.com>,
        Jiri Benc <jbenc@...hat.com>
Subject: Re: [PATCH] net: Make synchronize_net() be expedited only when it's
 really need

>
> Your original patch did not provide any test results. Only the fact synchronize_rcu_expedited()
> completes faster than plain synchronize_rcu(). But this is an obvious fact
> just because of the design, and this is described even in the documentation.
> Beleive me, I don't want to offend you this words, but it's strange you hadn't
> gone the way you suggest me.

Well, I guess you missed the fine changelog.

Please carefully read it :

https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/commit/?id=be3fc413da9eb17cce0991f214ab019d16c88c41

And you' ll noticed I had an Ack from Paul E. McKenney, the RCU maintainer.