netdev - Re: [PATCH bpf-next] selftests/bpf: fix test_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6a5408cb-631a-02cf-3fbd-78d0eb289ed8@iogearbox.net>
Date:   Tue, 23 Jan 2018 18:50:04 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Alexei Starovoitov <ast@...nel.org>, davem@...emloft.net
Cc:     guro@...com, tj@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next] selftests/bpf: fix test_dev_cgroup

On 01/23/2018 05:48 AM, Alexei Starovoitov wrote:
> The test incorrectly doing
> mkdir /mnt/cgroup-test-work-dirtest-bpf-based-device-cgroup
> instead of
> mkdir /mnt/cgroup-test-work-dir/test-bpf-based-device-cgroup
> 
> somehow such mkdir succeeds and new directory appears:
> /mnt/cgroup-test-work-dir/cgroup-test-work-dirtest-bpf-based-device-cgroup
> 
> Later cleanup via nftw("/mnt/cgroup-test-work-dir", ...);
> doesn't walk this directory.
> "rmdir /mnt/cgroup-test-work-dir" succeeds, but bpf program and
> dangling cgroup stays in memory.
> That's a separate issue on a cgroup side.

Purely cgroup side with regards to internal cleanup (which then as a
side effect doesn't drop ref on the BPF prog)? Is a fix taken care of?

> For now fix the test.
> 
> Fixes: 37f1ba0909df ("selftests/bpf: add a test for device cgroup controller")
> Signed-off-by: Alexei Starovoitov <ast@...nel.org>

Applied to bpf-next, thanks Alexei!