netdev - Re: [PATCH net-next] cxgb4/cxgb4vf: add support for ndo_set_vf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180123.132735.489931369264140861.davem@davemloft.net>
Date:   Tue, 23 Jan 2018 13:27:35 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     ganeshgr@...lsio.com
Cc:     netdev@...r.kernel.org, nirranjan@...lsio.com,
        indranil@...lsio.com, venkatesh@...lsio.com
Subject: Re: [PATCH net-next] cxgb4/cxgb4vf: add support for ndo_set_vf_vlan

From: Ganesh Goudar <ganeshgr@...lsio.com>
Date: Tue, 23 Jan 2018 21:52:03 +0530

> +	cmd.op_to_vfn = htonl(FW_CMD_OP_V(FW_ACL_VLAN_CMD) |
> +			      FW_CMD_REQUEST_F | FW_CMD_READ_F);
> +
> +	/* Note: Do not enable the ACL */
> +	cmd.en_to_len16 = htonl((unsigned int)FW_LEN16(cmd));

This is inconsistent with the rest of the driver which uses
cpu_to_be??() when filling in firmware commands.

Please fix this.

Thank you.