netdev - Re: [PATCH bpf] bpf: test_maps: cleanup sockmaps when test ends

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180123050108.fcmh4phzcclxer2f@ast-mbp>
Date:   Mon, 22 Jan 2018 21:01:09 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Prashant Bhole <bhole_prashant_q7@....ntt.co.jp>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Shuah Khan <shuahkh@....samsung.com>, netdev@...r.kernel.org,
        John Fastabend <john.fastabend@...il.com>
Subject: Re: [PATCH bpf] bpf: test_maps: cleanup sockmaps when test ends

On Tue, Jan 23, 2018 at 01:55:30PM +0900, Prashant Bhole wrote:
> 
> 
> On 1/23/2018 1:38 PM, Alexei Starovoitov wrote:
> > On Tue, Jan 23, 2018 at 01:30:44PM +0900, Prashant Bhole wrote:
> > > Bug: BPF programs and maps related to sockmaps test exist in
> > > memory even after test_maps ends
> > > 
> > > This patch fixes it by empyting sockmaps when test ends.
> > > 
> > > Fixes: 6f6d33f3b3d0f ("bpf: selftests add sockmap tests")
> > > Signed-off-by: Prashant Bhole <bhole_prashant_q7@....ntt.co.jp>
> > 
> > that's a fine workaround and I'm planning to apply this patch
> > to bpf-next, but it's not a fix. The sockmap should have cleaned
> > itself up.
> 
> Ok. Do I need to re-submit it targeted to -bpf-next and without fixes tag?

No need. It's fine.