netdev - Re: [PATCH net-next v2] net: link_watch: mark bonding link events urgent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a1aa3577-295a-f0a3-4d0c-73a26a1fad3d@cumulusnetworks.com>
Date:   Tue, 23 Jan 2018 12:19:28 +0200
From:   Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:     Roopa Prabhu <roopa@...ulusnetworks.com>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, dsa@...ulusnetworks.com, jiri@...nulli.us
Subject: Re: [PATCH net-next v2] net: link_watch: mark bonding link events
 urgent

On 22/01/18 18:07, Roopa Prabhu wrote:
> From: Roopa Prabhu <roopa@...ulusnetworks.com>
> 
> It takes 1sec for bond link down notification to hit user-space
> when all slaves of the bond go down. 1sec is too long for
> protocol daemons in user-space relying on bond notification
> to recover (eg: multichassis lag implementations in user-space).
> Since the link event code already marks team device port link events
>  as urgent, this patch moves the code to cover all lag ports and master.
> 
> Signed-off-by: Roopa Prabhu <roopa@...ulusnetworks.com>
> ---
> v2: use netif_is_lag_* api's as suggested by jiri
> 
>  net/core/link_watch.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/core/link_watch.c b/net/core/link_watch.c
> index 9828616..e38e641 100644
> --- a/net/core/link_watch.c
> +++ b/net/core/link_watch.c
> @@ -92,7 +92,7 @@ static bool linkwatch_urgent_event(struct net_device *dev)
>  	if (dev->ifindex != dev_get_iflink(dev))
>  		return true;
>  
> -	if (dev->priv_flags & IFF_TEAM_PORT)
> +	if (netif_is_lag_port(dev) || netif_is_lag_master(dev))
>  		return true;
>  
>  	return netif_carrier_ok(dev) &&	qdisc_tx_changing(dev);
> 

Reviewed-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>