netdev - Re: [PATCH net-next] sctp: reset ret in again path in sctp_for_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180123120908.GA22398@hmswarspite.think-freely.org>
Date:   Tue, 23 Jan 2018 07:09:08 -0500
From:   Neil Horman <nhorman@...driver.com>
To:     Xin Long <lucien.xin@...il.com>
Cc:     network dev <netdev@...r.kernel.org>, linux-sctp@...r.kernel.org,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
        davem@...emloft.net
Subject: Re: [PATCH net-next] sctp: reset ret in again path in
 sctp_for_each_transport

On Tue, Jan 23, 2018 at 06:22:25PM +0800, Xin Long wrote:
> Commit 97a6ec4ac021 ("rhashtable: Change rhashtable_walk_start to
> return void") only initialized ret for the first time, when going
> to again path, the next tsp could be NULL. Without resetting ret,
> cb_done would be called with tsp as NULL.
> 
> A kernel crash was caused by this when running sctpdiag testcase
> in sctp-tests.
> 
> Note that this issue doesn't affect net.git yet.
> 
> Fixes: 97a6ec4ac021 ("rhashtable: Change rhashtable_walk_start to return void")
> Signed-off-by: Xin Long <lucien.xin@...il.com>
> ---
>  net/sctp/socket.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/net/sctp/socket.c b/net/sctp/socket.c
> index 7ff444e..a40fa53 100644
> --- a/net/sctp/socket.c
> +++ b/net/sctp/socket.c
> @@ -4860,9 +4860,10 @@ int sctp_for_each_transport(int (*cb)(struct sctp_transport *, void *),
>  			    struct net *net, int *pos, void *p) {
>  	struct rhashtable_iter hti;
>  	struct sctp_transport *tsp;
> -	int ret = 0;
> +	int ret;
>  
>  again:
> +	ret = 0;
>  	sctp_transport_walk_start(&hti);
>  
>  	tsp = sctp_transport_get_idx(net, &hti, *pos + 1);
> -- 
> 2.1.0
> 
> 
Acked-by: Neil Horman <nhorman@...driver.com>