netdev - Re: [PATCH net-next] net/ipv6: Do not allow route add with a device that is down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180124124829.GA31174@splinter.mtl.com>
Date:   Wed, 24 Jan 2018 14:48:29 +0200
From:   Ido Schimmel <idosch@...sch.org>
To:     David Ahern <dsahern@...il.com>
Cc:     netdev@...r.kernel.org, yoshfuji@...ux-ipv6.org,
        idosch@...lanox.com
Subject: Re: [PATCH net-next] net/ipv6: Do not allow route add with a device
 that is down

On Tue, Jan 23, 2018 at 07:13:43PM -0800, David Ahern wrote:
> IPv6 allows routes to be installed when the device is not up (admin up).
> Worse, it does not mark it as LINKDOWN. IPv4 does not allow it and really
> there is no reason for IPv6 to allow it, so check the flags and deny if
> device is admin down.
> 
> Signed-off-by: David Ahern <dsahern@...il.com>

I figured people might complain if I change that, but I obviously prefer
to have it like IPv4. Agree with Roopa about the error code.

Thanks