netdev - Re: [patch net] mlxsw: spectrum_router: Don't log an error on missing neighbor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180124.105904.919163369493094197.davem@davemloft.net>
Date:   Wed, 24 Jan 2018 10:59:04 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jiri@...nulli.us
Cc:     netdev@...r.kernel.org, idosch@...lanox.com, mlxsw@...lanox.com
Subject: Re: [patch net] mlxsw: spectrum_router: Don't log an error on
 missing neighbor

From: Jiri Pirko <jiri@...nulli.us>
Date: Wed, 24 Jan 2018 10:02:09 +0100

> From: Yuval Mintz <yuvalm@...lanox.com>
> 
> Driver periodically samples all neighbors configured in device
> in order to update the kernel regarding their state. When finding
> an entry configured in HW that doesn't show in neigh_lookup()
> driver logs an error message.
> This introduces a race when removing multiple neighbors -
> it's possible that a given entry would still be configured in HW
> as its removal is still being processed but is already removed
> from the kernel's neighbor tables.
> 
> Simply remove the error message and gracefully accept such events.
> 
> Fixes: c723c735fa6b ("mlxsw: spectrum_router: Periodically update the kernel's neigh table")
> Fixes: 60f040ca11b9 ("mlxsw: spectrum_router: Periodically dump active IPv6 neighbours")
> Signed-off-by: Yuval Mintz <yuvalm@...lanox.com>
> Reviewed-by: Ido Schimmel <idosch@...lanox.com>
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>

Applied and queued up for -stable, thanks.