netdev - Re: [PATCH net-next 02/12] net: sched: prepare for reimplementation of tc_cls_common_offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180124114856.6d446749@cakuba.netronome.com>
Date:   Wed, 24 Jan 2018 11:48:56 -0800
From:   Jakub Kicinski <kubakici@...pl>
To:     David Miller <davem@...emloft.net>
Cc:     dsahern@...il.com, daniel@...earbox.net, john.fastabend@...il.com,
        jiri@...nulli.us, netdev@...r.kernel.org,
        oss-drivers@...ronome.com, aring@...atatu.com
Subject: Re: [PATCH net-next 02/12] net: sched: prepare for reimplementation
 of tc_cls_common_offload_init()

On Wed, 24 Jan 2018 10:37:59 -0500 (EST), David Miller wrote:
> From: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Date: Tue, 23 Jan 2018 18:45:58 -0800
> 
> > Rename tc_cls_common_offload_init() to tc_cls_common_offload_init__()
> > and add a new implementation which also takes flags argument.  We will
> > only set extack if flags indicate that offload is forced (skip_sw)
> > otherwise driver errors should be ignored, as they don't influence
> > the overall filter installation.
> > 
> > Note that we need the tc_skip_hw() helper for new version, therefore
> > it is added later in the file.
> > 
> > Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> > Reviewed-by: Simon Horman <simon.horman@...ronome.com>  
> 
> Just give the old function a name which makes it's transient purpose
> clear rather than this weird foo__() convention.
> 
> Something like tc_cls_common_offload_init_compat() or even
> tc_cls_common_offload_init_deprecated().
> 
> Then people can say "oh, that is serving as a temporary compat
> function until everyone is converted, then it is deleted"
> 
> Thanks.

Good point, I'll do that shortly.

Thank you!