netdev - Re: [PATCH net] ipv6: Fix getsockopt() for sockets with default IPV6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180123.195552.1920721101735461569.davem@davemloft.net>
Date:   Tue, 23 Jan 2018 19:55:52 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     ben.hutchings@...ethink.co.uk
Cc:     kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH net] ipv6: Fix getsockopt() for sockets with default
 IPV6_AUTOFLOWLABEL

From: Ben Hutchings <ben.hutchings@...ethink.co.uk>
Date: Mon, 22 Jan 2018 20:06:42 +0000

> Commit 513674b5a2c9 ("net: reevalulate autoflowlabel setting after
> sysctl setting") removed the initialisation of
> ipv6_pinfo::autoflowlabel and added a second flag to indicate
> whether this field or the net namespace default should be used.
> 
> The getsockopt() handling for this case was not updated, so it
> currently returns 0 for all sockets for which IPV6_AUTOFLOWLABEL is
> not explicitly enabled.  Fix it to return the effective value, whether
> that has been set at the socket or net namespace level.
> 
> Fixes: 513674b5a2c9 ("net: reevalulate autoflowlabel setting after sysctl ...")
> Signed-off-by: Ben Hutchings <ben.hutchings@...ethink.co.uk>
> ---
> This will need to go to stable, as the earlier commit did.

Applied and queued up for -stable, thanks Ben.